Processing: Option to save output layer by the side#589
Merged
martinRenou merged 10 commits intogeojupyter:mainfrom Apr 4, 2025
Merged
Processing: Option to save output layer by the side#589martinRenou merged 10 commits intogeojupyter:mainfrom
martinRenou merged 10 commits intogeojupyter:mainfrom
Conversation
Contributor
Contributor
|
Integration tests report: appsharing.space |
Member
|
As discussed during the last dev meeting, would you like to add a checkbox in the processing form to make this optional? We can look into saving the user choice in cache in a follow-up PR. |
Member
Author
Yes, i'm working on this
Sure |
8cfc102 to
461a91e
Compare
Member
Author
|
Failure, is again due to the flaky snapshot. Let's try updating that in this PR |
Member
Author
|
Bot please update snapshots |
Member
Author
|
How come a lot of snapshots updated? |
4 tasks
martinRenou
reviewed
Apr 3, 2025
packages/base/src/formbuilder/objectform/process/bufferProcessForm.tsx
Outdated
Show resolved
Hide resolved
ui-tests/tests/filters.spec.ts-snapshots/no-filter-chromium-linux.png
Outdated
Show resolved
Hide resolved
42486bc to
461a91e
Compare
HaudinFlorence
pushed a commit
to HaudinFlorence/jupytergis
that referenced
this pull request
Jan 28, 2026
* Save output layer by the side instead of embedding into the jgis file * Minimal buffer process form * embedOutputLayer? * handle `embedOutputLayer` * lint * default true * push schema * define `embedOutputLayer` in schema * not needed * Remove bufferProcessForm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
embedOutputLayer.mp4
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--589.org.readthedocs.build/en/589/
💡 JupyterLite preview: https://jupytergis--589.org.readthedocs.build/en/589/lite